Wasmtime GitHub notifications bot (Jun 10 2025 at 21:58): Wasmtime GitHub notifications bot (Jun 10 2025 at 21:58):alexcrichton requested abrown for a review on PR #11008.
Wasmtime GitHub notifications bot (Jun 10 2025 at 21:58):alexcrichton opened PR #11008 from alexcrichton:x64-xchg to bytecodealliance:main:
This required a custom visit function because printing operands has to happen in one order to match Capstone but allocating operations has to happen in another order to satisfy regalloc, so so one of the two has to be custom.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 10 2025 at 21:58):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11008.
Wasmtime GitHub notifications bot (Jun 10 2025 at 23:42):abrown commented on PR #11008:
Should we just bite the bullet and migrate the custom display functions to have a signature like
pub fn inst<R: Registers>(f: &mut std::fmt::Formatter, inst: &inst::inst<R>) -> std::fmt::Result? It looks like the same thing @rahulchaphalkar is running into over in: https://github.com/bytecodealliance/wasmtime/pull/10836#discussion_r2138322890.
Wasmtime GitHub notifications bot (Jun 11 2025 at 00:37):alexcrichton commented on PR #11008:
I figure this'll need a custom something, but I don't mind it being either a display or a visit. Seems reasonable to me to prefer a custom display so I'm happy to hold off until that merges
Wasmtime GitHub notifications bot (Jun 11 2025 at 03:10):github-actions[bot] commented on PR #11008:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 12 2025 at 19:19):abrown submitted PR review.
Wasmtime GitHub notifications bot (Jun 12 2025 at 22:07):alexcrichton updated PR #11008.
Wasmtime GitHub notifications bot (Jun 12 2025 at 22:08):alexcrichton has enabled auto merge for PR #11008.
Wasmtime GitHub notifications bot (Jun 12 2025 at 23:42):alexcrichton updated PR #11008.
Wasmtime GitHub notifications bot (Jun 13 2025 at 00:28):alexcrichton merged PR #11008.
Last updated: Dec 06 2025 at 06:05 UTC