Wasmtime GitHub notifications bot (Jun 10 2025 at 15:48): Wasmtime GitHub notifications bot (Jun 10 2025 at 15:48):alexcrichton opened PR #11000 from alexcrichton:aarch64-remove-closure-from-load-constant to bytecodealliance:main:
This was added in #5366 but upon reflection I don't think that it's necessary as almost all of the definitions reuse the temporary register as the destination register as well. The original motivation looks like it's relate to the SSA-ness of instructions but I believe the way it's generated it's all SSA-valid, so this commit removes the temp allocation function and uses
rd, the destination register, unconditionally instead.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 10 2025 at 15:48):alexcrichton requested fitzgen for a review on PR #11000.
Wasmtime GitHub notifications bot (Jun 10 2025 at 15:48):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11000.
Wasmtime GitHub notifications bot (Jun 10 2025 at 18:10):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 10 2025 at 18:32):fitzgen merged PR #11000.
Last updated: Dec 06 2025 at 06:05 UTC