Stream: git-wasmtime

Topic: wasmtime / PR #10997 winch: Generalize `with_scratch` fun...

Wasmtime GitHub notifications bot (Jun 10 2025 at 14:48):

alexcrichton requested saulecabrera for a review on PR #10997.

Wasmtime GitHub notifications bot (Jun 10 2025 at 14:48):

alexcrichton requested abrown for a review on PR #10997.

Wasmtime GitHub notifications bot (Jun 10 2025 at 14:48):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10997.

Wasmtime GitHub notifications bot (Jun 10 2025 at 14:48):

alexcrichton opened PR #10997 from alexcrichton:winch-generalize to bytecodealliance:main:

• Support any return value, not just Result<()>
• Use FnOnce instead of FnMut

This meant that many Ok(()) values could be dropped, but other values using ? needed to explicitly annotate the return type which is done by returning anyhow::Ok(()) to force the error type.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 10 2025 at 15:05):

saulecabrera submitted PR review:

Nice, thanks!

Wasmtime GitHub notifications bot (Jun 10 2025 at 16:08):

saulecabrera merged PR #10997.

Last updated: Dec 06 2025 at 06:05 UTC