Stream: git-wasmtime

Topic: wasmtime / PR #10992 stack-switching: fix continuation st...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 21:45):

posborne requested pchickey for a review on PR #10992.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 21:45):

posborne requested wasmtime-core-reviewers for a review on PR #10992.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 21:45):

posborne opened PR #10992 from posborne:stack-switching-backtrace-fix to bytecodealliance:main:

A refactor during the stack switching runtime changes introduced a defect not present in the base stack switching code. The chunks iterator call ends up skipping elements and the windows call would require pulling in something like itertools::zip_longest to work, so I just restored an impl closer to the original (but with more fine-grained unsafe calls).

This code has coverage but only in the final round of stack switching changes.


Original Discussion: https://github.com/bytecodealliance/wasmtime/pull/10388#discussion_r2114747895. I didn't look closely enough when I took on this approach and w/o testing this slipped through (though can't really be hit yet).

Failing Test with current main + cranelift changes + tests: https://github.com/posborne/wasmtime/actions/runs/15538863221/job/43744530801#step:19:1165

CC @frank-emrich, @dhil

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->


Last updated: Dec 06 2025 at 06:05 UTC