Wasmtime GitHub notifications bot (Jun 09 2025 at 20:16): Wasmtime GitHub notifications bot (Jun 09 2025 at 20:16):alexcrichton opened PR #10991 from alexcrichton:x64-migirate-xmm-unary-rmr-imm to bytecodealliance:main:
This required definitions for
{v,}pshuf{lw,hw,d}as well as reusing existing definitions forvround*instructions. While no other changes were needed in the assembler itself there was one minor ISLE change: thevrounds{s,d}instructions have a register operand that is used to copy to the upper bits of the result and this was not previously modeled in ISLE. Instead during emission the destination had its upper bits preserved, but this has proven to be problematic in the past where the upper bits being carried from previous instructions can cause unintended data dependencies and drastically slowing down tight loops. This commit fills in this operand withxmm_zerowhich means the upper bits will now be zeroed and any data dependencies from before will be severed.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 09 2025 at 20:16):alexcrichton requested cfallin for a review on PR #10991.
Wasmtime GitHub notifications bot (Jun 09 2025 at 20:16):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10991.
Wasmtime GitHub notifications bot (Jun 09 2025 at 21:45):github-actions[bot] commented on PR #10991:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 10 2025 at 15:23):cfallin requested abrown for a review on PR #10991.
Wasmtime GitHub notifications bot (Jun 10 2025 at 15:23):cfallin commented on PR #10991:
(Handing off review to @abrown if you don't mind -- I'm traveling this week at a conference)
Wasmtime GitHub notifications bot (Jun 10 2025 at 17:37):abrown submitted PR review.
Wasmtime GitHub notifications bot (Jun 10 2025 at 18:01):abrown merged PR #10991.
Last updated: Dec 06 2025 at 06:05 UTC