Stream: git-wasmtime

Topic: wasmtime / PR #10990 Allow embedders to override / define...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 18:48):

fibonacci1729 opened PR #10990 from fibonacci1729:allow-overriding-forbidden-headers to bytecodealliance:main:

This PR allows embeddings to wholesale override / define what headers for an outgoing request are acceptable.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 18:49):

fibonacci1729 has marked PR #10990 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 18:49):

fibonacci1729 requested dicej for a review on PR #10990.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 18:49):

fibonacci1729 requested wasmtime-core-reviewers for a review on PR #10990.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 19:56):

lann submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 19:56):

lann created PR review comment:

Given that the immediate goal is just to allow TE maybe we should just propose removing this line?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 19:56):

lann created PR review comment:

While this behavior better matches the method doc comment it _is_ a breaking change, and in the unfortunate compiler-won't-help-you sense. :thinking:

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 20:11):

alexcrichton submitted PR review:

@pchickey you probably have thoughts on this too?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 20:11):

alexcrichton created PR review comment:

I suspect this (and wasi-common below) were unintentional?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 20:22):

lann submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 20:22):

lann created PR review comment:

OK not "just": it would probably make sense to also enforce trailers as the only acceptable value, which is actually pretty sensible anyway since it is the only value that is allowed across http versions today.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2025 at 01:00):

fibonacci1729 updated PR #10990.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2025 at 16:27):

fibonacci1729 closed without merge PR #10990.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2025 at 16:27):

fibonacci1729 commented on PR #10990:

Closing this to pursue another solution that isn't as surprising a breaking change.

Last updated: Dec 06 2025 at 06:05 UTC