Stream: git-wasmtime

Topic: wasmtime / PR #10977 x64: Migrate push/pop to the new as...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 07 2025 at 16:41):

alexcrichton opened PR #10977 from alexcrichton:x64-push-pop to bytecodealliance:main:

Figured these would be some interesting instruction shapes. This adds a
helper to the ISLE generation to skip some instructions and the "push"
instructions are skipped as they're not needed in ISLE and would
otherwise require binding new instruction shapes which didn't seem worth
it. Additionally many items in gen_asm.rs were made private (removed
pub).

view this post on Zulip Wasmtime GitHub notifications bot (Jun 07 2025 at 16:41):

alexcrichton requested abrown for a review on PR #10977.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 07 2025 at 16:41):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10977.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 17:35):

abrown submitted PR review:

Makes sense!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2025 at 17:57):

abrown merged PR #10977.

Last updated: Dec 06 2025 at 06:05 UTC