Stream: git-wasmtime

Topic: wasmtime / PR #10970 Remove FileInputStream from public API

Wasmtime GitHub notifications bot (Jun 06 2025 at 22:05):

jeffcharles opened PR #10970 from jeffcharles:remove-file-input-stream-from-public-api to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
I suspect based on looking at documentation for this struct that this struct was never intended to be part of wasmtime-wasi's public API. Particularly given that external crates do not have access to the File struct that its new method expects as a parameter. The File struct is public within the module but it's not exported by the crate so consumers outside the crate cannot create an instance of this struct to pass as a parameter to FileInputStream's new method. IMHO it's a bit confusing as a user of wasmtime-wasi for the type to exist on the public API if it isn't usable outside the crate.

Wasmtime GitHub notifications bot (Jun 06 2025 at 22:05):

jeffcharles requested alexcrichton for a review on PR #10970.

Wasmtime GitHub notifications bot (Jun 06 2025 at 22:05):

jeffcharles requested wasmtime-core-reviewers for a review on PR #10970.

Wasmtime GitHub notifications bot (Jun 06 2025 at 23:58):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jun 07 2025 at 00:19):

pchickey merged PR #10970.

Last updated: Dec 06 2025 at 07:03 UTC