Stream: git-wasmtime

Topic: wasmtime / PR #10965 `cranelift-frontend`: Refactor how v...

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:48):

fitzgen opened PR #10965 from fitzgen:frontend-variables to bytecodealliance:main:

Rather than requiring users to construct a Variable entity out of thin air and then declare it to the frontend, declaring a new variable now returns the new Variable entity. And instead of having a SecondaryMap<Variable, Type> inside of FunctionBuilder we now have a PrimaryMap<Variable, Type>. Using variables in cranelift-frontend should generally feel a little bit better and more idiomatic now.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:48):

fitzgen requested cfallin for a review on PR #10965.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:48):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #10965.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:48):

fitzgen requested dicej for a review on PR #10965.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:48):

fitzgen requested wasmtime-core-reviewers for a review on PR #10965.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:51):

fitzgen updated PR #10965.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:54):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:54):

bjorn3 created PR review comment:

These should be declare_var, not define_var, right?

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:57):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:57):

fitzgen created PR review comment:

Whoops, yep, thanks

Wasmtime GitHub notifications bot (Jun 06 2025 at 21:01):

fitzgen updated PR #10965.

Wasmtime GitHub notifications bot (Jun 06 2025 at 21:06):

cfallin submitted PR review:

Nice -- much cleaner!

Wasmtime GitHub notifications bot (Jun 06 2025 at 21:06):

cfallin has enabled auto merge for PR #10965.

Wasmtime GitHub notifications bot (Jun 06 2025 at 21:48):

cfallin merged PR #10965.

Last updated: Dec 06 2025 at 06:05 UTC