Wasmtime GitHub notifications bot (Jun 06 2025 at 20:26): Wasmtime GitHub notifications bot (Jun 06 2025 at 20:26):alexcrichton opened PR #10963 from alexcrichton:internal-crates-are-internal to bytecodealliance:main:
This commit is an attempt to more clearly flag internal crates in this project as internal and not intended for external use. Specifically:
- Many crates are renamed from
wasmtime-footowasmtime-internal-foo.- All of these crates now have
INTERNAL: ...in their crates.io description.- All of these crates now have a warning at the top of their documentation discouraging use.
This change is a result of rustsec/advisory-db#1999 where the goal is to be crystal clear from a project perspective that usage of these crates are highly discouraged and not supported. We'll still probably get such advisories but we won't be considering them CVEs from the project itself due to the internal nature of these crates and the discouraging warnings.
Some concrete changes used here are:
- Inter-crate dependencies still use
wasmtime_foofor naming and do so with Cargo's package-renaming features.- Crate renames are specified at the workspace level so the rename is only in one locations and all other inherit it.
- Contribution documentation now has some brief guidelines about crate organization.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 06 2025 at 20:26):alexcrichton requested pchickey for a review on PR #10963.
Wasmtime GitHub notifications bot (Jun 06 2025 at 20:26):alexcrichton requested wasmtime-core-reviewers for a review on PR #10963.
Wasmtime GitHub notifications bot (Jun 06 2025 at 20:26):alexcrichton requested wasmtime-default-reviewers for a review on PR #10963.
Wasmtime GitHub notifications bot (Jun 06 2025 at 20:30):alexcrichton updated PR #10963.
Wasmtime GitHub notifications bot (Jun 06 2025 at 20:31):alexcrichton updated PR #10963.
Wasmtime GitHub notifications bot (Jun 06 2025 at 20:49):pchickey submitted PR review:
Thanks, Alex
Wasmtime GitHub notifications bot (Jun 06 2025 at 20:53):alexcrichton updated PR #10963.
Wasmtime GitHub notifications bot (Jun 06 2025 at 21:09):alexcrichton has enabled auto merge for PR #10963.
Wasmtime GitHub notifications bot (Jun 06 2025 at 21:47):alexcrichton merged PR #10963.
Last updated: Dec 06 2025 at 07:03 UTC