alexcrichton opened PR #10958 from alexcrichton:x64-movddup to bytecodealliance:main:
Enables removing the
XmmUnaryRmRUnalignedinstruction variant. Additionally this exposed a shortcoming where Cranelift didn't have access for testing for SSE3 in ISLE (not to be confused with SSSE3). Additionallymovddupwas incorrectly classified as SSSE3 so this commit fills out some infrastructure to use SSE3 instead of SSSE3. There are more instructions as well that are mis-classified under SSSE3 which I'll address in a follow-up.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #10958.
alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10958.
alexcrichton commented on PR #10958:
On the topic of SSE3 testing lacking in Cranelift and instructions mis-classified as SSSE3 instead of SSE3 AFAIK it's benign and otherwise dates back to #6025 where I assume I misread something and got the classification wrong. I think that
movddupis the only SSE3 instruction that Cranelift supports at this time too.
github-actions[bot] commented on PR #10958:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
fitzgen submitted PR review.
fitzgen merged PR #10958.
Last updated: Dec 06 2025 at 06:05 UTC