Stream: git-wasmtime

Topic: wasmtime / PR #10956 Cranelift: Refactor legalization suc...

Wasmtime GitHub notifications bot (Jun 06 2025 at 16:54):

fitzgen opened PR #10956 from fitzgen:legalization-separate-traversal to bytecodealliance:main:

Notably, make sure that we aren't using the same FuncCursor for traversal and modification, as that makes it hard to follow when the traversal is being moved forward and backed up.

Additionally, this makes it so that when we legalize an instruction, we only back up the cursor to continue legalization until we reach a fixed-point when said legalization resulted in something that actually requires further legalization. This should be mildly more efficient, since we can avoid an unnecessary loop iteration and its match on the just-legalized instruction data and opcode.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 06 2025 at 16:54):

fitzgen requested abrown for a review on PR #10956.

Wasmtime GitHub notifications bot (Jun 06 2025 at 16:54):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #10956.

Wasmtime GitHub notifications bot (Jun 06 2025 at 17:02):

fitzgen updated PR #10956.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:02):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:02):

alexcrichton created PR review comment:

I think this might be revisiting too much since prev_pos is never updated?

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:03):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:03):

fitzgen created PR review comment:

Heh, yeah I actually fixed that in a later commit and then realized I never updated the PR and was in the middle of doing that rn

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:03):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:03):

fitzgen created PR review comment:

good eye!

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:06):

fitzgen updated PR #10956.

Wasmtime GitHub notifications bot (Jun 06 2025 at 20:06):

fitzgen has enabled auto merge for PR #10956.

Wasmtime GitHub notifications bot (Jun 06 2025 at 21:00):

alexcrichton commented on PR #10956:

I think that's https://github.com/bytecodealliance/wasmtime/issues/10000

Wasmtime GitHub notifications bot (Jun 06 2025 at 21:47):

alexcrichton merged PR #10956.

Last updated: Dec 06 2025 at 06:05 UTC