Wasmtime GitHub notifications bot (Jun 06 2025 at 00:21): Wasmtime GitHub notifications bot (Jun 06 2025 at 00:21):alexcrichton opened PR #10947 from alexcrichton:fix-clash to bytecodealliance:main:
This commit fixes two issues: (1) is that
--emit-clifgenerates file names that are different from symbol names and (2) is that--emit-cliffor components today has collisions on filenames which means that output files can get corrupted. Currently (2) is causing spurious failures in CI due to the test added in #10939 being the first test with a component and functions in modules where they clash to emit the same file.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 06 2025 at 00:21):alexcrichton has marked PR #10947 as ready for review.
Wasmtime GitHub notifications bot (Jun 06 2025 at 00:21):alexcrichton requested pchickey for a review on PR #10947.
Wasmtime GitHub notifications bot (Jun 06 2025 at 00:21):alexcrichton requested wasmtime-core-reviewers for a review on PR #10947.
Wasmtime GitHub notifications bot (Jun 06 2025 at 00:32):alexcrichton updated PR #10947.
Wasmtime GitHub notifications bot (Jun 06 2025 at 00:51):alexcrichton updated PR #10947.
Wasmtime GitHub notifications bot (Jun 06 2025 at 02:21):github-actions[bot] commented on PR #10947:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "wasmtime:api", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 06 2025 at 15:37):alexcrichton updated PR #10947.
Wasmtime GitHub notifications bot (Jun 06 2025 at 15:54):cfallin submitted PR review:
going to go ahead and review to unblock CI -- thanks!
Wasmtime GitHub notifications bot (Jun 06 2025 at 15:55):cfallin has enabled auto merge for PR #10947.
Wasmtime GitHub notifications bot (Jun 06 2025 at 16:08):fitzgen commented on PR #10947:
Thanks!
Wasmtime GitHub notifications bot (Jun 06 2025 at 16:20):cfallin merged PR #10947.
Last updated: Dec 06 2025 at 06:05 UTC