Stream: git-wasmtime

Topic: wasmtime / PR #10946 asm: follow up on DSL nits

Wasmtime GitHub notifications bot (Jun 06 2025 at 00:20):

abrown opened PR #10946 from abrown:follow-up to bytecodealliance:main:

Some final review comments went unaddressed in #10855 that this change resolve, primarily using LIG for non-vector definitions. I was going to add .wig() everywhere but, after thinking about it, it _is_ the default value for vex() and leaving it out reduces the amount of information one has to parse. This also cleans up a few extra lines I saw lying around.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 06 2025 at 00:20):

abrown requested fitzgen for a review on PR #10946.

Wasmtime GitHub notifications bot (Jun 06 2025 at 00:20):

abrown requested wasmtime-compiler-reviewers for a review on PR #10946.

Wasmtime GitHub notifications bot (Jun 06 2025 at 00:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 06 2025 at 14:31):

alexcrichton commented on PR #10946:

That flaky test failure should be fixed in https://github.com/bytecodealliance/wasmtime/pull/10947

Wasmtime GitHub notifications bot (Jun 06 2025 at 16:21):

alexcrichton merged PR #10946.

Last updated: Dec 06 2025 at 06:05 UTC