Wasmtime GitHub notifications bot (Jun 05 2025 at 21:54): Wasmtime GitHub notifications bot (Jun 05 2025 at 21:54):fitzgen opened PR #10939 from fitzgen:fact-enum to bytecodealliance:main:
instead of treating them like variants that don't have payloads, just check that the discriminant is in bounds.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 05 2025 at 21:54):fitzgen requested alexcrichton for a review on PR #10939.
Wasmtime GitHub notifications bot (Jun 05 2025 at 21:54):fitzgen requested wasmtime-core-reviewers for a review on PR #10939.
Wasmtime GitHub notifications bot (Jun 05 2025 at 21:57):alexcrichton submitted PR review:
If you're feeling particularly enterprising, mind adding a test to
tests/misc_testsuite/component-model/*.wast? I think it should be reasonably easy to hook this all up and we could assert that traps don't happen for in-bounds values but do happen for out-of-bounds values
Wasmtime GitHub notifications bot (Jun 05 2025 at 22:33):fitzgen updated PR #10939.
Wasmtime GitHub notifications bot (Jun 05 2025 at 22:34):fitzgen commented on PR #10939:
If you're feeling particularly enterprising, mind adding a test to
tests/misc_testsuite/component-model/*.wast?I'll give this a shot in a follow up PR
Wasmtime GitHub notifications bot (Jun 05 2025 at 22:46):fitzgen has enabled auto merge for PR #10939.
Wasmtime GitHub notifications bot (Jun 05 2025 at 22:54):fitzgen updated PR #10939.
Wasmtime GitHub notifications bot (Jun 05 2025 at 23:20):fitzgen merged PR #10939.
Last updated: Dec 06 2025 at 07:03 UTC