Wasmtime GitHub notifications bot (Jun 05 2025 at 20:24): Wasmtime GitHub notifications bot (Jun 05 2025 at 20:24):alexcrichton opened PR #10935 from alexcrichton:make-safe-function-safe to bytecodealliance:main:
I mistakenly thought that this would be an
unsafefunction due to reasons that aren't applicable, and I'm not aware of any reason why this function should beunsafe, so mark it safe.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 05 2025 at 20:24):alexcrichton requested wasmtime-core-reviewers for a review on PR #10935.
Wasmtime GitHub notifications bot (Jun 05 2025 at 20:24):alexcrichton requested dicej for a review on PR #10935.
Wasmtime GitHub notifications bot (Jun 05 2025 at 21:54):dicej submitted PR review.
Wasmtime GitHub notifications bot (Jun 05 2025 at 21:54):dicej created PR review comment:
Is the sentence regarding safety in the doc comment above still relevant, or should it be removed?
Wasmtime GitHub notifications bot (Jun 05 2025 at 21:55):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 05 2025 at 21:55):alexcrichton created PR review comment:
Oops no it should be removed
Wasmtime GitHub notifications bot (Jun 05 2025 at 21:55):alexcrichton updated PR #10935.
Wasmtime GitHub notifications bot (Jun 05 2025 at 21:56):alexcrichton has enabled auto merge for PR #10935.
Wasmtime GitHub notifications bot (Jun 05 2025 at 23:33):alexcrichton updated PR #10935.
Wasmtime GitHub notifications bot (Jun 05 2025 at 23:33):alexcrichton has enabled auto merge for PR #10935.
Wasmtime GitHub notifications bot (Jun 06 2025 at 16:45):alexcrichton merged PR #10935.
Last updated: Dec 06 2025 at 07:03 UTC