Stream: git-wasmtime

Topic: wasmtime / PR #10896 Add a new `ComponentInstanceId` type

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:19):

alexcrichton opened PR #10896 from alexcrichton:component-instance-id to bytecodealliance:main:

This is intended to be similar to InstanceId, but used for components.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:19):

alexcrichton requested dicej for a review on PR #10896.

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:19):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10896.

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:19):

alexcrichton commented on PR #10896:

This is split out of https://github.com/bytecodealliance/wasmtime/pull/10870 and is needed for a method of defining globals where globals can be flags for instances.

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:42):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:42):

dicej created PR review comment:

Will we also be adding a component_instance_mut method for getting a &mut ComponentInstance from a &mut self?

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:45):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:45):

alexcrichton created PR review comment:

Indeed! I'll go ahead and add that in to indicate that it's desired too.

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:46):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:46):

alexcrichton created PR review comment:

Hm ok no just kidding. There's not a safe instance_mut accessor due to my historical (and probably irrational paranoia). When we move more towards indices though I believe it should be safe to add that, but it'll need some other changes too.

Wasmtime GitHub notifications bot (Jun 02 2025 at 20:34):

alexcrichton merged PR #10896.

Last updated: Dec 06 2025 at 06:05 UTC