Wasmtime GitHub notifications bot (May 31 2025 at 17:37): Wasmtime GitHub notifications bot (May 31 2025 at 17:37):alexcrichton opened PR #10886 from alexcrichton:unpack-requires-aligned to bytecodealliance:main:
This commit fixes a minor mistake from #10842 where the instructions weren't tagged as requiring aligned loads meaning that wasm loads could get folded into the instruction, producing unexpected alignment faults.
A test is added here which would trigger this a bit more quickly during fuzzing as fuzzing runs
*.wasttests with a variety of codegen parameters, and would in theory eventually run this without AVX.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 31 2025 at 17:37):alexcrichton requested cfallin for a review on PR #10886.
Wasmtime GitHub notifications bot (May 31 2025 at 17:37):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10886.
Wasmtime GitHub notifications bot (May 31 2025 at 17:37):alexcrichton requested fitzgen for a review on PR #10886.
Wasmtime GitHub notifications bot (May 31 2025 at 17:37):alexcrichton requested wasmtime-core-reviewers for a review on PR #10886.
Wasmtime GitHub notifications bot (May 31 2025 at 18:49):alexcrichton updated PR #10886.
Wasmtime GitHub notifications bot (Jun 02 2025 at 13:52):abrown submitted PR review:
Good catch! We should probably add a
validaterule for this at some point; I keep missing these in reviews.
Wasmtime GitHub notifications bot (Jun 02 2025 at 14:40):alexcrichton updated PR #10886.
Wasmtime GitHub notifications bot (Jun 02 2025 at 14:40):alexcrichton has enabled auto merge for PR #10886.
Wasmtime GitHub notifications bot (Jun 02 2025 at 15:45):alexcrichton merged PR #10886.
Last updated: Dec 06 2025 at 06:05 UTC