Stream: git-wasmtime

Topic: wasmtime / PR #10884 Refactor float-to-int conversion bounds


view this post on Zulip Wasmtime GitHub notifications bot (May 31 2025 at 01:48):

alexcrichton opened PR #10884 from alexcrichton:refactor-float-bounds to bytecodealliance:main:

This commit deduplicates a number of locations throughout the codebase that contain the bounds for float-to-int conversions. These bounds are relatively subtle and not easy to get right so it's probably best to keep them all centralized in one location.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2025 at 01:48):

alexcrichton requested fitzgen for a review on PR #10884.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2025 at 01:48):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10884.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2025 at 01:48):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10884.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2025 at 01:48):

alexcrichton requested wasmtime-default-reviewers for a review on PR #10884.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2025 at 03:05):

github-actions[bot] commented on PR #10884:

Subscribe to Label Action

cc @cfallin, @fitzgen, @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "isle", "pulley", "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jun 02 2025 at 16:01):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 02 2025 at 16:05):

alexcrichton updated PR #10884.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 02 2025 at 16:05):

alexcrichton has enabled auto merge for PR #10884.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 02 2025 at 17:28):

alexcrichton merged PR #10884.


Last updated: Dec 06 2025 at 06:05 UTC