wasmtime / PR #10880 Refactor `vm::Instance::vmctx_plus_o... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #10880 Refactor `vm::Instance::vmctx_plus_o...

Wasmtime GitHub notifications bot (May 31 2025 at 01:28):

alexcrichton edited PR #10880.

Wasmtime GitHub notifications bot (May 31 2025 at 01:28):

alexcrichton has marked PR #10880 as ready for review.

Wasmtime GitHub notifications bot (May 31 2025 at 01:28):

Ok I have now applied the refactorings intended and this I believe preserves the send/sync-ness by default a bit better. This is by no means all that's necessary to uphold that, but it's at least not regressing too much.

Wasmtime GitHub notifications bot (May 31 2025 at 01:29):

alexcrichton commented on PR #10880:

I should also note this is split from https://github.com/bytecodealliance/wasmtime/pull/10870

Wasmtime GitHub notifications bot (Jun 02 2025 at 15:59):

fitzgen submitted PR review:

Nice

Wasmtime GitHub notifications bot (Jun 02 2025 at 15:59):

fitzgen created PR review comment:

    /// * Something in the VMContext is being read or written. In that case use
    ///   `vmctx_plus_offset` or `vmctx_plus_offset_mut` if possible due to
    ///   that having a safer lifetime.

Right?

Wasmtime GitHub notifications bot (Jun 02 2025 at 16:01):

alexcrichton updated PR #10880.

Wasmtime GitHub notifications bot (Jun 02 2025 at 16:01):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2025 at 16:01):

alexcrichton created PR review comment:

Oops, yes!

Wasmtime GitHub notifications bot (Jun 02 2025 at 16:01):

alexcrichton has enabled auto merge for PR #10880.

Wasmtime GitHub notifications bot (Jun 02 2025 at 18:11):

alexcrichton merged PR #10880.

Last updated: Dec 06 2025 at 07:03 UTC