Wasmtime GitHub notifications bot (May 30 2025 at 20:17): Wasmtime GitHub notifications bot (May 30 2025 at 20:17):alexcrichton opened PR #10875 from alexcrichton:fix-miri-stacked-borrows to bytecodealliance:main:
This commit adds a new tests which MIRI flags a stacked borrows violation with and then fixes the test. This has to do with recursively calling WebAssembly and juggling the various bits of mutable state associated with the Pulley VM. I don't believe that this is a soundness issue in the sense of miscompiles, but it's nevertheless something good to fix.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 30 2025 at 20:17):alexcrichton requested dicej for a review on PR #10875.
Wasmtime GitHub notifications bot (May 30 2025 at 20:17):alexcrichton requested wasmtime-core-reviewers for a review on PR #10875.
Wasmtime GitHub notifications bot (May 30 2025 at 21:07):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 30 2025 at 21:07):fitzgen created PR review comment:
Never deallocated for the lifetime of the store, right? We aren't leaking Pulley VMs indefinitely. Would be good to clarify that in this comment.
Wasmtime GitHub notifications bot (May 30 2025 at 21:11):alexcrichton updated PR #10875.
Wasmtime GitHub notifications bot (May 30 2025 at 21:11):alexcrichton has enabled auto merge for PR #10875.
Wasmtime GitHub notifications bot (May 30 2025 at 21:52):alexcrichton merged PR #10875.
Last updated: Dec 06 2025 at 06:05 UTC