Wasmtime GitHub notifications bot (May 27 2025 at 16:24): Wasmtime GitHub notifications bot (May 27 2025 at 16:24):MangoPeachGrape requested alexcrichton for a review on PR #10841.
Wasmtime GitHub notifications bot (May 27 2025 at 16:24):MangoPeachGrape opened PR #10841 from MangoPeachGrape:c-api/component-model/more to bytecodealliance:main.
Wasmtime GitHub notifications bot (May 27 2025 at 16:24):MangoPeachGrape requested wasmtime-core-reviewers for a review on PR #10841.
Wasmtime GitHub notifications bot (May 27 2025 at 16:28):MangoPeachGrape updated PR #10841.
Wasmtime GitHub notifications bot (May 27 2025 at 21:16):alexcrichton submitted PR review:
Thanks for this!
Random thought: do you know how we might run asan or something to check for memory leaks in CI? I'm not sure how to do that myself but it'd be nice to ensure that we're not accidentally leaking any memory with this representation anywhere
Wasmtime GitHub notifications bot (May 27 2025 at 21:36):alexcrichton merged PR #10841.
Wasmtime GitHub notifications bot (May 29 2025 at 12:39):MangoPeachGrape commented on PR #10841:
@alexcrichton I'm not really sure, as the C and Rust allocators are different, right? Would you compile both with LeakSanitizer?
See:
https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html#leaksanitizer
https://clang.llvm.org/docs/LeakSanitizer.html
Wasmtime GitHub notifications bot (May 29 2025 at 15:28):alexcrichton commented on PR #10841:
They should both bottom out in
mallocandfreeby default, so I think ASAN might be enough (which IIRC also detects leaks in addition to other things). If LSAN works though that also seems reasonable to me
Wasmtime GitHub notifications bot (Jun 02 2025 at 22:04):pchickey commented on PR #10841:
I recently hooked up wasmtime and a C api project (though not wasmtime's C api) to asan to find my own bugs of that sort. I found that I needed to:
- compile the rust with nightly and
RUSTFLAGS=-Zsanitizer=address- install and build the C with an llvm/clang toolchain that is relatively recent so the sanitizer is compatible with the information emitted by rustc, since my CI package manager's was too old I used LLVM-20.1 which is the same version rust is using in nightly
- build the C sources with
-fsanitize=address,undefined -fno-omit-frame-pointercflags
Wasmtime GitHub notifications bot (Jun 02 2025 at 22:05):pchickey edited a comment on PR #10841:
I recently hooked up wasmtime and a C api project (though not wasmtime's C api) to asan to find my own bugs of that sort. I found that I needed to:
- compile the rust with nightly and
RUSTFLAGS=-Zsanitizer=address- install and build the C with an llvm/clang toolchain that is relatively recent so the sanitizer is compatible with the information emitted by rustc, since my CI package manager's was too old I used LLVM-20.1 which is the same version rust is using in nightly. I don't have a sense for when rust will drift far enough from that to break something, but it works right now anyway.
- build the C sources with
-fsanitize=address,undefined -fno-omit-frame-pointercflags
Wasmtime GitHub notifications bot (Jun 02 2025 at 22:06):pchickey edited a comment on PR #10841:
I recently hooked up wasmtime and a C api project (though not wasmtime's C api) to asan to find my own bugs of that sort. I found that I needed to:
- compile the rust with nightly and
RUSTFLAGS=-Zsanitizer=address- install and build the C with an llvm/clang toolchain that is relatively recent so the sanitizer is compatible with the information emitted by rustc, since my CI package manager's was too old I used LLVM-20.1 which is the same version rust is using in nightly. I don't have a sense for when rust will drift far enough from that to break something, but it works right now anyway.
- build the C sources with
-fsanitize=address,undefined -fno-omit-frame-pointercflags- set
ASAN_SYMBOLIZER_PATH=<install location of LLVM-20.1.0-Linux-X64>/bin/llvm-symbolizerto get symbols in asan's traces
Wasmtime GitHub notifications bot (Jun 02 2025 at 22:09):pchickey edited a comment on PR #10841:
I recently hooked up wasmtime and a C api project (though not wasmtime's C api) to asan to find my own bugs of that sort. I found that I needed to:
- compile the rust with nightly and
RUSTFLAGS=-Zsanitizer=address- install and build the C with an llvm/clang toolchain that is relatively recent so the sanitizer is compatible with the information emitted by rustc, since my CI package manager's was too old I used LLVM-20.1 which is the same version rust is using in nightly. I don't have a sense for when rust will drift far enough from that to break something, but it works right now anyway.
- build the C sources with
-fsanitize=address,undefined -fno-omit-frame-pointercflags- set
ASAN_SYMBOLIZER_PATH=<install location of LLVM-20.1.0-Linux-X64>/bin/llvm-symbolizerto get symbols in asan's tracesAlso, beware that running debug builds of cranelift under asan will be egregiously, obscenely slow.
Last updated: Dec 06 2025 at 07:03 UTC