Wasmtime GitHub notifications bot (May 27 2025 at 15:33): Wasmtime GitHub notifications bot (May 27 2025 at 15:33):alexcrichton opened PR #10838 from alexcrichton:clippy-useless-conversions to bytecodealliance:main:
We've got lots of types in Wasmtime and convert between them quite a lot, but often over time conversions become unnecessary through refactorings or similar. This will hopefully enable us to clean up some conversions as they come up to try to have as few as possible ideally.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 27 2025 at 15:33):alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #10838.
Wasmtime GitHub notifications bot (May 27 2025 at 15:33):alexcrichton requested abrown for a review on PR #10838.
Wasmtime GitHub notifications bot (May 27 2025 at 15:33):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10838.
Wasmtime GitHub notifications bot (May 27 2025 at 15:33):alexcrichton requested dicej for a review on PR #10838.
Wasmtime GitHub notifications bot (May 27 2025 at 15:33):alexcrichton requested wasmtime-core-reviewers for a review on PR #10838.
Wasmtime GitHub notifications bot (May 27 2025 at 15:33):alexcrichton requested wasmtime-default-reviewers for a review on PR #10838.
Wasmtime GitHub notifications bot (May 27 2025 at 15:59):abrown created PR review comment:
?
Wasmtime GitHub notifications bot (May 27 2025 at 15:59):abrown submitted PR review:
Makes sense!
Wasmtime GitHub notifications bot (May 27 2025 at 16:07):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 27 2025 at 16:07):alexcrichton created PR review comment:
This is handling this configuration:
where in test-mode
.into()is required, but in non-test mode.into()is unnecessary. I figured it's probably best to just expect the lint to fire here in non-test mode instead of changing the actual code which seemed invasive.
Wasmtime GitHub notifications bot (May 27 2025 at 16:23):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 27 2025 at 16:23):abrown created PR review comment:
What I meant (and should have written out) is that the "test/not" part of the
reasonmessage was hard to parse.
Wasmtime GitHub notifications bot (May 27 2025 at 16:28):alexcrichton updated PR #10838.
Wasmtime GitHub notifications bot (May 27 2025 at 16:28):alexcrichton has enabled auto merge for PR #10838.
Wasmtime GitHub notifications bot (May 27 2025 at 17:09):alexcrichton merged PR #10838.
Last updated: Dec 06 2025 at 06:05 UTC