Stream: git-wasmtime

Topic: wasmtime / PR #10832 asm: model a way to modify the lower...

Wasmtime GitHub notifications bot (May 23 2025 at 22:19):

abrown opened PR #10832 from abrown:asm-opcode-mod to bytecodealliance:main:

The x86 ISA includes a special format that, for certain instructions, writes the low three bits of the destination register into the low three bits of the opcode. This is specified with +rb, +rw, +rd, and +ro in the reference manual. This change adds a way to model this when defining instructions, e.g., rex(...).rb().

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 23 2025 at 22:19):

abrown requested cfallin for a review on PR #10832.

Wasmtime GitHub notifications bot (May 23 2025 at 22:19):

abrown requested wasmtime-compiler-reviewers for a review on PR #10832.

Wasmtime GitHub notifications bot (May 23 2025 at 22:19):

abrown requested alexcrichton for a review on PR #10832.

Wasmtime GitHub notifications bot (May 23 2025 at 22:59):

cfallin submitted PR review:

LGTM, thanks!

Wasmtime GitHub notifications bot (May 23 2025 at 22:59):

cfallin created PR review comment:

Would it make sense to make this field an enum with None, Rb, Rw, Rd, Ro as options and a .bits() method? Not too important either way but that might make this a little more self-documenting/nicer.

Wasmtime GitHub notifications bot (May 24 2025 at 00:43):

abrown submitted PR review.

Wasmtime GitHub notifications bot (May 24 2025 at 00:43):

abrown created PR review comment:

:+1: I have another branch with that... abandoned because it was more lines. But, yeah, let me revive that since you mentioned it! I'll just add it to this PR and move the documentation around.

Wasmtime GitHub notifications bot (May 24 2025 at 02:25):

abrown updated PR #10832.

Wasmtime GitHub notifications bot (May 24 2025 at 02:26):

abrown has enabled auto merge for PR #10832.

Wasmtime GitHub notifications bot (May 24 2025 at 02:50):

abrown updated PR #10832.

Wasmtime GitHub notifications bot (May 24 2025 at 03:24):

abrown merged PR #10832.

Last updated: Dec 06 2025 at 07:03 UTC