Stream: git-wasmtime

Topic: wasmtime / PR #10831 Remove mul support based on assembler


view this post on Zulip Wasmtime GitHub notifications bot (May 23 2025 at 18:28):

jlb6740 opened PR #10831 from jlb6740:remove-mulss-mulsd-from-current-codegen to bytecodealliance:main:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2025 at 18:28):

jlb6740 requested cfallin for a review on PR #10831.

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2025 at 18:28):

jlb6740 requested wasmtime-compiler-reviewers for a review on PR #10831.

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2025 at 18:29):

jlb6740 commented on PR #10831:

@abrown You implemented mul support. Not sure if there was a reason for not removing the older support so wanted to notify you of this pr.

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2025 at 18:44):

cfallin requested abrown for a review on PR #10831.

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2025 at 18:44):

cfallin commented on PR #10831:

(moving review over to @abrown as he has more context)

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2025 at 19:44):

github-actions[bot] commented on PR #10831:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2025 at 20:46):

abrown submitted PR review:

Thanks for catching this; LGTM!

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2025 at 21:31):

abrown merged PR #10831.


Last updated: Dec 06 2025 at 07:03 UTC