Stream: git-wasmtime

Topic: wasmtime / PR #10822 x64: convert all XMM minimum/maximum...


view this post on Zulip Wasmtime GitHub notifications bot (May 21 2025 at 23:29):

abrown opened PR #10822 from abrown:asm-max-min to bytecodealliance:main:

This converts both the floating-point min* and max* instructions as well as all of the packed integer versions of those instructions.

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2025 at 23:29):

abrown requested cfallin for a review on PR #10822.

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2025 at 23:29):

abrown requested wasmtime-compiler-reviewers for a review on PR #10822.

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2025 at 23:41):

cfallin submitted PR review:

LGTM, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2025 at 23:42):

cfallin commented on PR #10822:

(It looks like there are some build failures due to some remaining uses of the removed functions?)

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2025 at 23:51):

abrown updated PR #10822.

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2025 at 23:52):

abrown commented on PR #10822:

(It looks like there are some build failures due to some remaining uses of the removed functions?)

Yeah, apparently it's still used in tests so I moved it to #[cfg(test)].

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2025 at 23:52):

abrown has enabled auto merge for PR #10822.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2025 at 00:15):

abrown updated PR #10822.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2025 at 00:51):

abrown merged PR #10822.


Last updated: Dec 06 2025 at 06:05 UTC