Stream: git-wasmtime

Topic: wasmtime / PR #10821 winch: Use innermost frame to emit `...

Wasmtime GitHub notifications bot (May 21 2025 at 15:21):

saulecabrera opened PR #10821 from saulecabrera:winch-use-innermost-frame-br-table to bytecodealliance:main:

Prior to this commit, the lowering of br_table used the default target as the relative reference to pop ABI results. This approach is not ideal, as it leads to a loss of precision regarding the stack pointer position, causing unmet invariants at jump sites for all other branches.

This commit, instead, takes advantage of the fact that all jumps are "outward" and uses the innermost frame to pop ABI results when lowering br_table. This ensures two main things:

• The stack pointer offset is correctly positioned according to the expectations of the innermost block's end sequence, which will be handled in the next eventual end sequence.
• We meet the jump site invariants introduced by CodegenContext::br.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 21 2025 at 15:21):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #10821.

Wasmtime GitHub notifications bot (May 21 2025 at 15:21):

saulecabrera requested cfallin for a review on PR #10821.

Wasmtime GitHub notifications bot (May 21 2025 at 15:21):

saulecabrera requested wasmtime-core-reviewers for a review on PR #10821.

Wasmtime GitHub notifications bot (May 21 2025 at 15:21):

saulecabrera requested alexcrichton for a review on PR #10821.

Wasmtime GitHub notifications bot (May 21 2025 at 15:22):

saulecabrera commented on PR #10821:

I'm running the fuzzer locally. I'll report back later today.

Wasmtime GitHub notifications bot (May 21 2025 at 15:24):

saulecabrera updated PR #10821.

Wasmtime GitHub notifications bot (May 21 2025 at 16:47):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (May 21 2025 at 17:08):

alexcrichton merged PR #10821.

Last updated: Dec 06 2025 at 06:05 UTC