Stream: git-wasmtime

Topic: wasmtime / PR #10820 x64: Migrate div instructions to the...

Wasmtime GitHub notifications bot (May 20 2025 at 22:51):

alexcrichton requested abrown for a review on PR #10820.

Wasmtime GitHub notifications bot (May 20 2025 at 22:51):

alexcrichton opened PR #10820 from alexcrichton:x64-div to bytecodealliance:main:

This mostly required adding a new kind of operand representing a TrapCode and plumbing around a few bits and bobs to ensure that this compile-time-only-abstraction does not need to be accounted for in all the encoding bits.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 20 2025 at 22:51):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10820.

Wasmtime GitHub notifications bot (May 21 2025 at 01:05):

github-actions[bot] commented on PR #10820:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (May 21 2025 at 13:28):

alexcrichton updated PR #10820.

Wasmtime GitHub notifications bot (May 21 2025 at 17:25):

abrown submitted PR review.

Wasmtime GitHub notifications bot (May 21 2025 at 17:25):

abrown created PR review comment:

What if instead of "trap as an Operand" we add a field like Inst::trap? I'm concerned that trap codes aren't really operands after all _and_ that we already have a TrapCode hidden away in the Amode with all of its own machinery. Seems like it would be better to:

• define all instructions that can trap with something like inst(...).can_trap()
• decide whether we truly need to pass around trap codes in ISLE or if we can define them earlier, e.g., .can_trap(242)

Wasmtime GitHub notifications bot (May 22 2025 at 01:08):

alexcrichton updated PR #10820.

Wasmtime GitHub notifications bot (May 22 2025 at 01:09):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (May 22 2025 at 01:09):

alexcrichton created PR review comment:

Tried it out and I like it better too :+1:

Wasmtime GitHub notifications bot (May 22 2025 at 14:23):

alexcrichton updated PR #10820.

Wasmtime GitHub notifications bot (May 22 2025 at 15:51):

abrown submitted PR review:

Nice!

Wasmtime GitHub notifications bot (May 22 2025 at 16:12):

abrown merged PR #10820.

Last updated: Dec 06 2025 at 06:05 UTC