Wasmtime GitHub notifications bot (May 20 2025 at 19:06): Wasmtime GitHub notifications bot (May 20 2025 at 19:06):alexcrichton requested abrown for a review on PR #10816.
Wasmtime GitHub notifications bot (May 20 2025 at 19:06):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10816.
Wasmtime GitHub notifications bot (May 20 2025 at 19:06):alexcrichton opened PR #10816 from alexcrichton:x64-remove-shiftrr to bytecodealliance:main:
Shifts and rotates were all represented with
ShiftRand they're now all represented with individual instructions. Additionally the oldImm8{Gpr,Reg}abstractions were largely removed and/or replace to only be helpers in ISLE.This does regress pcc a bit more than it already is at due to the shift instructions not being special-cased for pcc processing.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 20 2025 at 19:12):alexcrichton updated PR #10816.
Wasmtime GitHub notifications bot (May 20 2025 at 19:35):cfallin commented on PR #10816:
This does regress pcc a bit more than it already is at due to the shift instructions not being special-cased for pcc processing.
No worries there -- it's already regressed since I last had time to try to push it forward so I'll need to make a comprehensive update in any case.
Wasmtime GitHub notifications bot (May 20 2025 at 20:46):github-actions[bot] commented on PR #10816:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (May 20 2025 at 21:50):abrown submitted PR review:
Nice; I'm loving all the removed code.
Wasmtime GitHub notifications bot (May 20 2025 at 22:11):abrown merged PR #10816.
Last updated: Dec 06 2025 at 06:05 UTC