Stream: git-wasmtime

Topic: wasmtime / PR #10813 Make debugtrap generate `brk #0xf000...

Wasmtime GitHub notifications bot (May 20 2025 at 12:02):

joshtriplett opened PR #10813 from joshtriplett:debugtrap to bytecodealliance:main:

Debuggers treat brk #0xf000 as a software breakpoint, so that they
know to skip over it when attempting to resume.

Fixes: https://github.com/bytecodealliance/wasmtime/issues/9726

Wasmtime GitHub notifications bot (May 20 2025 at 12:02):

joshtriplett requested abrown for a review on PR #10813.

Wasmtime GitHub notifications bot (May 20 2025 at 12:02):

joshtriplett requested wasmtime-compiler-reviewers for a review on PR #10813.

Wasmtime GitHub notifications bot (May 20 2025 at 12:03):

joshtriplett commented on PR #10813:

Note that I intentionally did not try to make the brk helper in isle accept a parameter here, because it is exclusively used to implement debugtrap.

Wasmtime GitHub notifications bot (May 20 2025 at 12:08):

bjorn3 commented on PR #10813:

https://github.com/bytecodealliance/wasmtime/blob/e82e178670945eb39ab337d2ec32acbdbb42eccf/cranelift/codegen/src/isa/aarch64/inst/emit.rs#L3122 needs to be updated too I think.

Wasmtime GitHub notifications bot (May 20 2025 at 12:31):

joshtriplett commented on PR #10813:

@bjorn3 Good catch, not sure how I missed that.

I just realized that I should have been running cargo test --all rather than cargo test.

Fixing.

Wasmtime GitHub notifications bot (May 20 2025 at 13:04):

joshtriplett edited a comment on PR #10813:

@bjorn3 Good catch, not sure how I missed that.

I just realized that I should have been enabling features when running cargo test.

Fixing.

Wasmtime GitHub notifications bot (May 20 2025 at 13:06):

joshtriplett updated PR #10813.

Wasmtime GitHub notifications bot (May 20 2025 at 13:30):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (May 20 2025 at 13:50):

alexcrichton merged PR #10813.

Last updated: Dec 06 2025 at 06:05 UTC