Wasmtime GitHub notifications bot (May 19 2025 at 21:02): Wasmtime GitHub notifications bot (May 19 2025 at 21:02):alexcrichton requested abrown for a review on PR #10810.
Wasmtime GitHub notifications bot (May 19 2025 at 21:02):alexcrichton opened PR #10810 from alexcrichton:migrate-some-instructions to bytecodealliance:main:
This includes
bsr,bsf,tzcnt,popcnt, andlzcnt.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 19 2025 at 21:02):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10810.
Wasmtime GitHub notifications bot (May 19 2025 at 21:21):alexcrichton updated PR #10810.
Wasmtime GitHub notifications bot (May 19 2025 at 22:46):github-actions[bot] commented on PR #10810:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (May 19 2025 at 23:48):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 19 2025 at 23:48):abrown created PR review comment:
I was struggling with this today with multiplication: is there no better way?
Wasmtime GitHub notifications bot (May 19 2025 at 23:49):abrown created PR review comment:
Thanks for this. Putting the
Fromover on the assembler side should be clearer!
Wasmtime GitHub notifications bot (May 20 2025 at 00:10):abrown merged PR #10810.
Wasmtime GitHub notifications bot (May 20 2025 at 12:14):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 20 2025 at 12:14):alexcrichton created PR review comment:
Oh heh I was just copying from code you wrote, so I alas don't have great ideas here :(
"fixing" this would probably involve something more invasive in Winch to have typed registers throughout the entire implementation rather than just the low-level assembler would be my guess, but that's a pretty big change
Last updated: Dec 06 2025 at 06:05 UTC