Wasmtime GitHub notifications bot (May 18 2025 at 22:04): Wasmtime GitHub notifications bot (May 18 2025 at 22:04):alexcrichton requested dicej for a review on PR #10793.
Wasmtime GitHub notifications bot (May 18 2025 at 22:04):alexcrichton opened PR #10793 from alexcrichton:doc-run-more to bytecodealliance:main:
Try to take the spirit of #10792 to improve our documentation for the
runcommand and how CLI arguments interact with the provided WebAssembly module.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 18 2025 at 22:04):alexcrichton requested wasmtime-default-reviewers for a review on PR #10793.
Wasmtime GitHub notifications bot (May 19 2025 at 17:16):abrown submitted PR review:
Apologies for the nits!
Wasmtime GitHub notifications bot (May 19 2025 at 17:16):abrown created PR review comment:
Just wondering: isn't there some WASI repository page somewhere that we can link to here in case anyone wants to dig into the difference between command and reactor components?
Wasmtime GitHub notifications bot (May 19 2025 at 17:16):abrown created PR review comment:
after the file itself. For example,
Wasmtime GitHub notifications bot (May 19 2025 at 17:16):abrown created PR review comment:
For both core modules and components, CLI arguments are passed via WASI. Core
Wasmtime GitHub notifications bot (May 19 2025 at 17:16):abrown created PR review comment:
will pass `["foo.wasm", "--bar", "baz"]` as the list of arguments to the module.
Wasmtime GitHub notifications bot (May 19 2025 at 17:16):abrown created PR review comment:
WASIp2 or later APIs. Arguments, flags, etc., are passed to the WebAssembly file
Wasmtime GitHub notifications bot (May 19 2025 at 17:16):abrown created PR review comment:
afterwards. For example,
Wasmtime GitHub notifications bot (May 19 2025 at 17:52):koke1997 submitted PR review.
Wasmtime GitHub notifications bot (May 19 2025 at 17:52):koke1997 created PR review comment:
Hey @abrown ,
I think this was mentioned in this comment - https://github.com/WebAssembly/WASI/issues/13#issuecomment-1188574599
So i think this the right repository - https://github.com/WebAssembly/component-model
There is post on blog for this topic which helped me to understand this topic - https://wasmcloud.com/blog/webassembly-patterns-command-reactor-library/
Wasmtime GitHub notifications bot (May 20 2025 at 13:57):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 20 2025 at 13:57):alexcrichton created PR review comment:
I'll update this to remove the "command" terminology since that's now-dated and instead just say "CLI program" in a few places here. I'd prefer to not have to bring up commands/reactors if possible since they're ideally only a historical feature.
Wasmtime GitHub notifications bot (May 20 2025 at 13:58):alexcrichton updated PR #10793.
Wasmtime GitHub notifications bot (May 20 2025 at 13:58):alexcrichton has enabled auto merge for PR #10793.
Wasmtime GitHub notifications bot (May 20 2025 at 14:32):alexcrichton merged PR #10793.
Last updated: Dec 06 2025 at 07:03 UTC