Stream: git-wasmtime

Topic: wasmtime / PR #10785 Update MSRV to 1.85.0

Wasmtime GitHub notifications bot (May 16 2025 at 08:50):

alexcrichton opened PR #10785 from alexcrichton:update-msrv to bytecodealliance:main:

This makes us eligible to update to the 2024 Rust edition but I'm planning on deferring that to a separate follow-up change.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 16 2025 at 08:50):

alexcrichton requested abrown for a review on PR #10785.

Wasmtime GitHub notifications bot (May 16 2025 at 08:50):

alexcrichton requested wasmtime-default-reviewers for a review on PR #10785.

Wasmtime GitHub notifications bot (May 16 2025 at 15:52):

abrown submitted PR review:

:+1: but I guess there's a few extra warnings to handle now.

Wasmtime GitHub notifications bot (May 18 2025 at 09:39):

alexcrichton requested dicej for a review on PR #10785.

Wasmtime GitHub notifications bot (May 18 2025 at 09:39):

alexcrichton updated PR #10785.

Wasmtime GitHub notifications bot (May 18 2025 at 09:39):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10785.

Wasmtime GitHub notifications bot (May 18 2025 at 09:54):

alexcrichton updated PR #10785.

Wasmtime GitHub notifications bot (May 18 2025 at 09:55):

alexcrichton updated PR #10785.

Wasmtime GitHub notifications bot (May 18 2025 at 12:15):

alexcrichton updated PR #10785.

Wasmtime GitHub notifications bot (May 18 2025 at 22:28):

alexcrichton updated PR #10785.

Wasmtime GitHub notifications bot (May 19 2025 at 13:05):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10785.

Wasmtime GitHub notifications bot (May 19 2025 at 13:05):

alexcrichton requested cfallin for a review on PR #10785.

Wasmtime GitHub notifications bot (May 19 2025 at 13:05):

alexcrichton updated PR #10785.

Wasmtime GitHub notifications bot (May 19 2025 at 13:09):

alexcrichton created PR review comment:

Digging into this, it looks like LLVM sees in the assertion below assert_eq!(cosf(x), cosf(x)) and then LLVM has built-in knowledge that cosf is pure so it's optimized out entirely. That means libm doesn't get linked at all, meaning later dlsym calls fail.

Using black_box here is apparently enough, but unsure how long it'll last necessarily.

Wasmtime GitHub notifications bot (May 19 2025 at 13:09):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (May 19 2025 at 13:18):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (May 19 2025 at 13:18):

alexcrichton created PR review comment:

For future posterity this is roughly what I was looking at. Basically we just need to preserve the reference to the cosf symbol. (and if anyone knows of a better way to do that let's definitely land that instead!)

Wasmtime GitHub notifications bot (May 19 2025 at 13:18):

alexcrichton has enabled auto merge for PR #10785.

Wasmtime GitHub notifications bot (May 19 2025 at 13:46):

alexcrichton merged PR #10785.

Last updated: Dec 06 2025 at 06:05 UTC