Wasmtime GitHub notifications bot (May 07 2025 at 20:40): Wasmtime GitHub notifications bot (May 07 2025 at 20:40):cfallin opened PR #10747 from cfallin:fix-too-many-return-values to bytecodealliance:main:
Prior versions of regalloc2 could not support more than 255 operands on an instruction, and together with the integrated return-value loads on call instructions introduced in #10502, this caused issues with calls with many returns. This PR upgrades to a version of RA2 that supports up to
2^16 - 1operands per instruction (well in excess of the maximum of 1000 return/result values per Wasm's implementation limits, for example).Fixes #10741.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 07 2025 at 20:40):cfallin requested alexcrichton for a review on PR #10747.
Wasmtime GitHub notifications bot (May 07 2025 at 20:40):cfallin requested wasmtime-core-reviewers for a review on PR #10747.
Wasmtime GitHub notifications bot (May 07 2025 at 20:40):cfallin requested wasmtime-default-reviewers for a review on PR #10747.
Wasmtime GitHub notifications bot (May 07 2025 at 20:43):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 07 2025 at 20:43):alexcrichton created PR review comment:
Could you add this as a
tests/misc_testsuite/*.wasttest as well so it gets tested on all architectures automatically? I figure it's ok to avoid running the test, just having it there compiled everywhere seems good
Wasmtime GitHub notifications bot (May 07 2025 at 20:44):cfallin commented on PR #10747:
In attempting to update
cargo vetmetadata, I'm seeing that perhaps we've failed to update for new crates:% cargo vet ERROR × There are some issues with your policy.audit-as-crates-io entries Error: × Some non-crates.io-fetched packages match published crates.io versions │ cranelift-srcgen:0.120.0 │ wasmtime-wasi-tls:33.0.0will need to work out exactly how we handle this again...
Wasmtime GitHub notifications bot (May 07 2025 at 20:45):cfallin updated PR #10747.
Wasmtime GitHub notifications bot (May 07 2025 at 20:45):cfallin submitted PR review.
Wasmtime GitHub notifications bot (May 07 2025 at 20:45):cfallin created PR review comment:
Done!
Wasmtime GitHub notifications bot (May 07 2025 at 20:47):alexcrichton commented on PR #10747:
Do you have the latest
cargo vetversion? (0.10.1 for me)Otherwise, before this PR, if you run
cargo vetdoes it change anything or have any errors?
Wasmtime GitHub notifications bot (May 07 2025 at 20:51):cfallin commented on PR #10747:
Yes, I have v0.10.1; and I actually get the same errors on
main. I need to context-switch and don't have time to dig into the innards of cargo-vet now so if someone else knows how to fix this it would be much appreciated...
Wasmtime GitHub notifications bot (May 07 2025 at 20:58):alexcrichton updated PR #10747.
Wasmtime GitHub notifications bot (May 07 2025 at 20:58):alexcrichton commented on PR #10747:
Looks like it needed a merge/rebase with main first
Wasmtime GitHub notifications bot (May 07 2025 at 20:58):alexcrichton has enabled auto merge for PR #10747.
Wasmtime GitHub notifications bot (May 07 2025 at 20:59):cfallin commented on PR #10747:
Ah, awesome, thanks -- that's what I get for not updating my local
mainwith regular development!
Wasmtime GitHub notifications bot (May 07 2025 at 21:38):alexcrichton merged PR #10747.
Last updated: Dec 06 2025 at 06:05 UTC