Stream: git-wasmtime

Topic: wasmtime / PR #10746 Move the `GetHost` trait used in `bi...

Wasmtime GitHub notifications bot (May 07 2025 at 18:47):

alexcrichton opened PR #10746 from alexcrichton:one-get-host to bytecodealliance:main:

Turns out we don't actually need to generate this GetHost trait, we can instead have it live in one location with extra documentation. There are already extra bounds on the Host associated type at all call-sites so there's no need to additionally have trait bounds in the trait definition, meaning the trait definition is always the same and it can move within Wasmtime.

This shouldn't have any impact on any embedders today, it's just moving things around.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 07 2025 at 18:47):

alexcrichton requested pchickey for a review on PR #10746.

Wasmtime GitHub notifications bot (May 07 2025 at 18:47):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10746.

Wasmtime GitHub notifications bot (May 07 2025 at 20:34):

alexcrichton requested dicej for a review on PR #10746.

Wasmtime GitHub notifications bot (May 07 2025 at 20:43):

dicej submitted PR review.

Wasmtime GitHub notifications bot (May 07 2025 at 20:43):

dicej created PR review comment:

Can we just remove this code rather than comment it out?

Wasmtime GitHub notifications bot (May 07 2025 at 20:43):

dicej created PR review comment:

/// unstable](https://github.com/rust-lang/rust/issues/97362). Alternatively one

Wasmtime GitHub notifications bot (May 07 2025 at 20:43):

dicej created PR review comment:

/// # Too much Detail

Nit: remove unnecessary hyphen

Wasmtime GitHub notifications bot (May 07 2025 at 20:49):

alexcrichton updated PR #10746.

Wasmtime GitHub notifications bot (May 07 2025 at 20:49):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (May 07 2025 at 20:49):

alexcrichton created PR review comment:

Oops yes that's my mistake!

Wasmtime GitHub notifications bot (May 07 2025 at 20:49):

alexcrichton has enabled auto merge for PR #10746.

Wasmtime GitHub notifications bot (May 07 2025 at 21:24):

alexcrichton merged PR #10746.

Last updated: Dec 06 2025 at 06:05 UTC