Stream: git-wasmtime

Topic: wasmtime / PR #10745 asm: refactor how REX prefixes are e...

Wasmtime GitHub notifications bot (May 07 2025 at 17:10):

abrown requested wasmtime-compiler-reviewers for a review on PR #10745.

Wasmtime GitHub notifications bot (May 07 2025 at 17:10):

abrown requested cfallin for a review on PR #10745.

Wasmtime GitHub notifications bot (May 07 2025 at 17:10):

abrown opened PR #10745 from abrown:asm-encoding-clean-up to bytecodealliance:main:

This does not change functionality; instead, it reorganizes how REX prefixes were encoded by the assembler to simplify code generation. RexFlags now becomes the more-correct RexPrefix and constructors like RexPrefix::two_op build the necessary byte for emission with RexPrefix::encode.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 07 2025 at 21:43):

abrown updated PR #10745.

Wasmtime GitHub notifications bot (May 07 2025 at 21:45):

cfallin submitted PR review:

Seems reasonable; thanks!

Wasmtime GitHub notifications bot (May 07 2025 at 21:45):

cfallin has enabled auto merge for PR #10745.

Wasmtime GitHub notifications bot (May 07 2025 at 22:18):

cfallin merged PR #10745.

Last updated: Dec 06 2025 at 06:05 UTC