Stream: git-wasmtime

Topic: wasmtime / PR #10739 Inline assembler-x64 `generated_file...

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2025 at 07:04):

adambratschikaye opened PR #10739 from adambratschikaye:abk/inline-assembler-x64-generated-files to bytecodealliance:main:

The public function generated_files in cranelift-assembler-x64 makes the generated rlib non-deterministic because it contains the full paths of generated files. But this function is only used in main.rs of the same crate, so this change inlines it there to keep the library artifact deterministic while maintaining the same behavior.

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2025 at 07:04):

adambratschikaye requested cfallin for a review on PR #10739.

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2025 at 07:04):

adambratschikaye requested wasmtime-compiler-reviewers for a review on PR #10739.

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2025 at 07:07):

adambratschikaye commented on PR #10739:

I think this should be the last PR needed to fix our build determinism/bazel caching issues.

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2025 at 13:54):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2025 at 14:17):

abrown merged PR #10739.

Last updated: Dec 06 2025 at 06:05 UTC