Wasmtime GitHub notifications bot (May 06 2025 at 14:42): Wasmtime GitHub notifications bot (May 06 2025 at 14:42):abrown opened PR #10734 from abrown:asm-phadd to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 06 2025 at 14:42):abrown requested fitzgen for a review on PR #10734.
Wasmtime GitHub notifications bot (May 06 2025 at 14:42):abrown requested wasmtime-compiler-reviewers for a review on PR #10734.
Wasmtime GitHub notifications bot (May 06 2025 at 14:43):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 06 2025 at 14:43):abrown created PR review comment:
Unfortunately, it's getting harder and harder to keep instruction definitions on a single line. This PR includes some re-formatting due to this change.
Wasmtime GitHub notifications bot (May 06 2025 at 14:46):abrown updated PR #10734.
Wasmtime GitHub notifications bot (May 06 2025 at 16:34):fitzgen created PR review comment:
We could alternatively add
#[rustfmt::skip]to this list, instead of messing with the whole crate's formatting settings, and dealing with random code reflowing when we have a new, extra-long instruction definition.
Wasmtime GitHub notifications bot (May 06 2025 at 16:34):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 06 2025 at 16:42):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 06 2025 at 16:42):abrown created PR review comment:
Yeah, I like that better, let me try that.
Wasmtime GitHub notifications bot (May 06 2025 at 17:07):abrown updated PR #10734.
Wasmtime GitHub notifications bot (May 06 2025 at 17:47):abrown merged PR #10734.
Last updated: Dec 06 2025 at 06:05 UTC