Stream: git-wasmtime

Topic: wasmtime / PR #10724 docs: Fix broken documentation link


view this post on Zulip Wasmtime GitHub notifications bot (May 03 2025 at 19:07):

GarmashAlex opened PR #10724 from GarmashAlex:brlink to bytecodealliance:main:

Fixes the link to the deterministic fuel section in
examples-deterministic-wasm-execution.md by changing the file extension
from .html to .md.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2025 at 19:07):

GarmashAlex requested pchickey for a review on PR #10724.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2025 at 19:07):

GarmashAlex requested wasmtime-default-reviewers for a review on PR #10724.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2025 at 19:09):

GarmashAlex commented on PR #10724:

attempt 2 with another broken link and a meaningful branch name))

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2025 at 19:16):

cfallin closed without merge PR #10724.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2025 at 19:16):

cfallin commented on PR #10724:

This link actually needs to be to the HTML -- the rendered content appears here, and changing the target of the link at the bottom from examples-interrupting-wasm.html to examples-interrupting-wasm.md creates a 404, unfortunately. I suspect this is a limitation in mdbook's rendering: it can translate normal links to whole Markdown files to the corresponding HTML files but not links with anchor targets.

(This appears to be tracked in rust-lang/mdBook#167, which on cursory skim looks like one of those "will never be fixed" kinds of issues, unfortunately...)

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2025 at 19:22):

cfallin reopened PR #10724.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2025 at 19:22):

cfallin commented on PR #10724:

Ah, actually, my experiment was incorrect -- I was playing with this in SUMMARY.md to ensure this kind of link worked, and apparently it doesn't there specifically (per the above issue) but it does in other files.

I wouldn't call this a "broken link" -- it does already work on the page I linked above -- but linking to the Markdown is more portable (will work with other rendering backends), so this PR seems reasonable -- thanks.


Last updated: Dec 06 2025 at 07:03 UTC