Wasmtime GitHub notifications bot (May 03 2025 at 15:11): Wasmtime GitHub notifications bot (May 03 2025 at 15:11):whosehang opened PR #10723 from whosehang:main to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->remove redundant word in comment
Wasmtime GitHub notifications bot (May 03 2025 at 15:11):whosehang requested dicej for a review on PR #10723.
Wasmtime GitHub notifications bot (May 03 2025 at 15:11):whosehang requested wasmtime-core-reviewers for a review on PR #10723.
Wasmtime GitHub notifications bot (May 03 2025 at 18:39):primoly submitted PR review.
Wasmtime GitHub notifications bot (May 03 2025 at 18:39):primoly created PR review comment:
/// stack-switching routines available in inline assembly. The fall-through case
Wasmtime GitHub notifications bot (May 03 2025 at 18:39):primoly created PR review comment:
/// A helper module to get reexported above in each case that we actually have
Wasmtime GitHub notifications bot (May 03 2025 at 18:50):cfallin commented on PR #10723:
The find-and-replace substituting "in in line asm" to "in line asm", and the edits to WIT files that are vendored and thus now fail a CI check to ensure they are unmodified, together with a history of this account making wide-ranging refactors across many projects in ways that show similar lack of careful work, lead me to suggest that we close this PR. While typo fixes are generally welcome, it's really not worth maintainers' time if it is done in a sloppy way that breaks things, and I don't want to encourage this pattern.
(I don't want to unilaterally make this decision though -- someone else please check me here; and perhaps we should have a project policy on this, as these "drive-by fix" PRs are becoming more and more frequent)
Wasmtime GitHub notifications bot (May 04 2025 at 01:08):whosehang commented on PR #10723:
Sorry for the confusion. I respect your suggestions, but before that, I will still make the changes as advised by @primoly.
Wasmtime GitHub notifications bot (May 04 2025 at 01:08):whosehang deleted a comment on PR #10723:
Sorry for the confusion. I respect your suggestions, but before that, I will still make the changes as advised by @primoly.
Wasmtime GitHub notifications bot (May 04 2025 at 01:09):whosehang commented on PR #10723:
The find-and-replace substituting "in in line asm" to "in line asm", and the edits to WIT files that are vendored and thus now fail a CI check to ensure they are unmodified, together with a history of this account making wide-ranging refactors across many projects in ways that show similar lack of careful work, lead me to suggest that we close this PR. While typo fixes are generally welcome, it's really not worth maintainers' time if it is done in a sloppy way that breaks things, and I don't want to encourage this pattern.
(I don't want to unilaterally make this decision though -- someone else please check me here; and perhaps we should have a project policy on this, as these "drive-by fix" PRs are becoming more and more frequent)
Sorry for the confusion. I respect your suggestions, but before that, I will still make the changes as advised by @primoly.
Please feel free to close this PR casually.
Wasmtime GitHub notifications bot (May 04 2025 at 01:12):whosehang updated PR #10723.
Wasmtime GitHub notifications bot (May 04 2025 at 01:12):whosehang requested wasmtime-default-reviewers for a review on PR #10723.
Wasmtime GitHub notifications bot (May 04 2025 at 01:13):whosehang submitted PR review.
Wasmtime GitHub notifications bot (May 04 2025 at 01:13):whosehang created PR review comment:
Thanks. Modified.
Wasmtime GitHub notifications bot (May 04 2025 at 01:13):whosehang submitted PR review.
Wasmtime GitHub notifications bot (May 04 2025 at 01:13):whosehang created PR review comment:
Thanks. Modified.
Wasmtime GitHub notifications bot (Jun 06 2025 at 15:34):cfallin closed without merge PR #10723.
Wasmtime GitHub notifications bot (Jun 06 2025 at 15:34):cfallin commented on PR #10723:
I'm going to go ahead and close this. This PR after updates has two other issues: (i) you're editing WIT files, and we have a CI check to see that they are the same as upstream (they are vendored sources); (ii) you introduce a random file in the root,
contributor.txt.My reasoning above stands -- small fixes are welcome, but they need to actually be fixes, and not introduce other problems; I don't really want to encourage a sort of low-effort typo-fix contribution where contributors are not making efforts to actually check things. All the best!
Last updated: Dec 06 2025 at 07:03 UTC