Stream: git-wasmtime

Topic: wasmtime / PR #10718 x64: use new versions of SSE `add` a...

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2025 at 20:43):

abrown opened PR #10718 from abrown:asm-clean-sse to bytecodealliance:main:

This set of changes builds on #10716 to clean up some of the old SseOpcode and related code. This adds some new instructions {add|sub}{ss|sd} and plumbs them throughout Cranelift and Winch.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2025 at 20:43):

abrown requested cfallin for a review on PR #10718.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2025 at 20:43):

abrown requested wasmtime-compiler-reviewers for a review on PR #10718.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2025 at 20:46):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2025 at 20:46):

abrown created PR review comment:

I'm not particularly happy with how much conversion code is needed. Having this here is certainly better than constructing all the necessary structs when trying to reason about some code sequence, but it still feels a bit much. This is not really anything that needs to be solved in this PR; in fact, it might be better solved once most instructions have been ported to the new assembler. But I bring it up to see if anyone has any good ideas for reducing this kind of thing.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2025 at 20:58):

cfallin submitted PR review:

This all looks pretty reasonable -- thanks!

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2025 at 20:58):

cfallin created PR review comment:

Yeah, I suspect we'll be able to think a little more clearly about this (or at least I know I will!) once we're able to DCE away all of the types that the old-style insts are keeping alive...

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2025 at 22:46):

github-actions[bot] commented on PR #10718:

Subscribe to Label Action

cc @cfallin, @fitzgen, @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle", "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2025 at 22:49):

abrown merged PR #10718.

Last updated: Dec 06 2025 at 06:05 UTC