Stream: git-wasmtime

Topic: wasmtime / PR #10716 asm: refactor using `RegClass` and `...

Wasmtime GitHub notifications bot (May 02 2025 at 19:49):

abrown opened PR #10716 from abrown:asm-xmm-mem-more to bytecodealliance:main:

This change involves no change in functionality but does pave the way for defining more SSE instructions in two ways:

• it adds the xmm_m32 and xmm_m64 variants as locations and changes rm128 to read xmm_m128 to match; this is necessary for SSE *ss and *sd instructions that load 32- and 64-bit values into XMM registers
• by returning RegClass from Location::reg_class it is much easier to distinguish what kind of a register an operand is using: previously this matched on the number of bits (i.e., 128) which does no longer makes sense for xmm_m32 and xmm_m64.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 02 2025 at 19:49):

abrown requested fitzgen for a review on PR #10716.

Wasmtime GitHub notifications bot (May 02 2025 at 19:49):

abrown requested wasmtime-compiler-reviewers for a review on PR #10716.

Wasmtime GitHub notifications bot (May 02 2025 at 20:10):

cfallin submitted PR review:

Good generalizations; thanks!

Wasmtime GitHub notifications bot (May 02 2025 at 20:10):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (May 02 2025 at 20:32):

cfallin merged PR #10716.

Last updated: Dec 06 2025 at 06:05 UTC