Wasmtime GitHub notifications bot (Apr 30 2025 at 16:23): Wasmtime GitHub notifications bot (Apr 30 2025 at 16:23):alexcrichton opened PR #10699 from alexcrichton:fix-more-rounding to bytecodealliance:main:
This commit fixes some more fallout found on oss-fuzz about the x64 generating rounding builtins when it shouldn't be. This situation is caused by simd float rounding instructions which the x64 backend lowers to libcall-per-element and now needs to move that logic to the frontend instead.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 30 2025 at 16:23):alexcrichton requested wasmtime-core-reviewers for a review on PR #10699.
Wasmtime GitHub notifications bot (Apr 30 2025 at 16:23):alexcrichton requested dicej for a review on PR #10699.
Wasmtime GitHub notifications bot (Apr 30 2025 at 16:46):alexcrichton commented on PR #10699:
cc @sunfishcode
Wasmtime GitHub notifications bot (Apr 30 2025 at 17:02):dicej submitted PR review:
I don't have enough Cranelift context yet to evaluate this properly, so I'll let Dan review it before approving, but LGTM.
Wasmtime GitHub notifications bot (May 05 2025 at 20:52):alexcrichton commented on PR #10699:
@fitzgen would you be able to take a look at this perhaps?
Wasmtime GitHub notifications bot (May 05 2025 at 20:56):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 05 2025 at 21:18):fitzgen merged PR #10699.
Last updated: Dec 06 2025 at 06:05 UTC