Stream: git-wasmtime

Topic: wasmtime / PR #10693 Add support for loading, storing and...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2025 at 23:31):

beetrees opened PR #10693 from beetrees:small-vector to bytecodealliance:main:

This PR adds support for loading, storing and bitcasting 16-bit, 32-bit and 64-bit vectors on the x64 and aarch64 backends (aarch64 already supported 64-bit vectors; additionally, the riscv64 backend already supports all three small vector sizes).

Fixes (for x64 and aarch64) #10254

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2025 at 23:31):

beetrees requested fitzgen for a review on PR #10693.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2025 at 23:31):

beetrees requested wasmtime-compiler-reviewers for a review on PR #10693.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2025 at 23:55):

beetrees updated PR #10693.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2025 at 23:56):

beetrees updated PR #10693.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 00:04):

beetrees updated PR #10693.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 00:05):

beetrees has marked PR #10693 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 01:28):

beetrees updated PR #10693.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 01:41):

beetrees updated PR #10693.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 01:42):

beetrees updated PR #10693.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 03:04):

github-actions[bot] commented on PR #10693:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 16:35):

fitzgen submitted PR review:

Thanks! Just a couple nitpicks to resolve before merging

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 16:35):

fitzgen created PR review comment:

Can this and above return a CodegenError::Unsupported instead of panicking?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 16:35):

fitzgen created PR review comment:

Tiny nitpick:

                    (4, Opcode::Vconst) => DataValue::V32(buffer.as_slice().try_into().expect("a 4-byte data buffer")),
                    (2, Opcode::Vconst) => DataValue::V16(buffer.as_slice().try_into().expect("a 2-byte data buffer")),

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 16:35):

fitzgen created PR review comment:

                    4 => DataValue::V32(mask.try_into().expect("a 4-byte vector mask")),
                    2 => DataValue::V16(mask.try_into().expect("a 2-byte vector mask")),

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 18:05):

beetrees submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 18:05):

beetrees created PR review comment:

Neither gen_store nor gen_load return a result (and neither do their callers, or their callers callers etc.), so a lot of functions would need to be changed to return results in order the propagate the error. Would that be desirable?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 19:29):

beetrees updated PR #10693.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 19:30):

beetrees submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 19:30):

beetrees created PR review comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 19:30):

beetrees submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 19:30):

beetrees created PR review comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 20:23):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 20:23):

fitzgen created PR review comment:

Ah I misread the diff and thought this was in a function that returned a result already. Given that it is not, and that it already panics on types that it cannot load/store, this is fine as-is.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 20:24):

fitzgen submitted PR review:

Thanks again!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 21:10):

beetrees updated PR #10693.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 21:11):

beetrees commented on PR #10693:

Fixed the Windows test failure.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 22:45):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2025 at 23:07):

fitzgen merged PR #10693.

Last updated: Jan 10 2026 at 20:04 UTC