Wasmtime GitHub notifications bot (Apr 24 2025 at 21:50): Wasmtime GitHub notifications bot (Apr 24 2025 at 21:50):alexcrichton opened PR #10672 from alexcrichton:use-features-as-bits to bytecodealliance:main:
This commit simplifies how wasm features are handled in module serialization. Instead of serializing a struct-of-bools this uses the bitflags representation that wasmparser has. There are prior checks to ensure that the wasmtime version for a serialized artifact is matching so we know that the bits mean the same things too.
This reduces the boilerplate in implementing new wasm proposals and should hopefully make it so that we get all the same benefit as before just with less maintenance over time.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 24 2025 at 21:51):alexcrichton requested pchickey for a review on PR #10672.
Wasmtime GitHub notifications bot (Apr 24 2025 at 21:51):alexcrichton requested wasmtime-core-reviewers for a review on PR #10672.
Wasmtime GitHub notifications bot (Apr 25 2025 at 17:10):pchickey submitted PR review:
Thanks, appreciate the deduplication!
Wasmtime GitHub notifications bot (Apr 25 2025 at 17:10):pchickey created PR review comment:
Could you leave a comment here for why gc gets this special case?
Wasmtime GitHub notifications bot (Apr 25 2025 at 19:08):alexcrichton updated PR #10672.
Wasmtime GitHub notifications bot (Apr 25 2025 at 19:09):alexcrichton has enabled auto merge for PR #10672.
Wasmtime GitHub notifications bot (Apr 25 2025 at 19:51):alexcrichton updated PR #10672.
Wasmtime GitHub notifications bot (Apr 25 2025 at 19:51):alexcrichton has disabled auto merge for PR #10672.
Wasmtime GitHub notifications bot (Apr 25 2025 at 19:51):alexcrichton has enabled auto merge for PR #10672.
Wasmtime GitHub notifications bot (Apr 25 2025 at 20:30):alexcrichton merged PR #10672.
Last updated: Dec 06 2025 at 06:05 UTC