Wasmtime GitHub notifications bot (Apr 24 2025 at 17:46): Wasmtime GitHub notifications bot (Apr 24 2025 at 17:46):alexcrichton requested pchickey for a review on PR #10669.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:46):alexcrichton requested wasmtime-core-reviewers for a review on PR #10669.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:46):alexcrichton opened PR #10669 from alexcrichton:uninhabited-dummy-types to bytecodealliance:main:
Reflecting a bit on #10657 I realized it might be better to define these dummy types as uninhabited in Rust instead of zero-size to help prevent their misuse by accident. This additionally changes the libcall intrinsics to requiring the
ssetarget feature on x86_64 since otherwise the types are uninhabited.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 25 2025 at 16:56):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Apr 25 2025 at 18:42):alexcrichton merged PR #10669.
Last updated: Dec 06 2025 at 07:03 UTC