Wasmtime GitHub notifications bot (Apr 24 2025 at 11:31): Wasmtime GitHub notifications bot (Apr 24 2025 at 11:31):vados-cosmonic opened PR #10666 from vados-cosmonic:refactor(docs)=update-code-blocks to bytecodealliance:main:
This commit udpates more instructions on various READMEs to avoid
$for easy copy-pasting, and also useconsolewhere appropriate.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 24 2025 at 11:31):vados-cosmonic requested fitzgen for a review on PR #10666.
Wasmtime GitHub notifications bot (Apr 24 2025 at 11:31):vados-cosmonic requested wasmtime-fuzz-reviewers for a review on PR #10666.
Wasmtime GitHub notifications bot (Apr 24 2025 at 11:31):vados-cosmonic requested wasmtime-compiler-reviewers for a review on PR #10666.
Wasmtime GitHub notifications bot (Apr 24 2025 at 11:31):vados-cosmonic requested wasmtime-default-reviewers for a review on PR #10666.
Wasmtime GitHub notifications bot (Apr 24 2025 at 11:31):vados-cosmonic requested wasmtime-core-reviewers for a review on PR #10666.
Wasmtime GitHub notifications bot (Apr 24 2025 at 12:57):github-actions[bot] commented on PR #10666:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "fuzzing", "isle", "wasmtime:docs"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: fuzzing, isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Apr 24 2025 at 15:04):dicej submitted PR review:
There are several blocks you've marked
consolewhich include$prompts and/or command output (I've added inline comments for a few, but then got tired of repeating myself). I'm thinking those should all be markedshell-sessiongiven they can't be meaningfully cut-and-pasted, correct?
Wasmtime GitHub notifications bot (Apr 24 2025 at 15:04):dicej created PR review comment:
This looks like it should remain a
shell-sessionblock given the$prompt and command output.
Wasmtime GitHub notifications bot (Apr 24 2025 at 15:04):dicej created PR review comment:
Given the
(lldb)prompt, it seems like this should be neitherconsolenorshbut maybe justtext?
Wasmtime GitHub notifications bot (Apr 24 2025 at 15:04):dicej created PR review comment:
Should this be
shell-session?
Wasmtime GitHub notifications bot (Apr 24 2025 at 15:04):dicej created PR review comment:
Should this be
shell-session?
Wasmtime GitHub notifications bot (Apr 24 2025 at 15:04):dicej created PR review comment:
Should this be
shell-session?
Wasmtime GitHub notifications bot (Apr 24 2025 at 16:56):vados-cosmonic submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2025 at 16:56):vados-cosmonic created PR review comment:
Yeah I think that's right, will update!
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:00):vados-cosmonic submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:00):vados-cosmonic created PR review comment:
Yup, will fix!
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:05):vados-cosmonic updated PR #10666.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:06):vados-cosmonic submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:06):vados-cosmonic created PR review comment:
Updated!
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:06):vados-cosmonic submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:06):vados-cosmonic created PR review comment:
Updated!
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:06):vados-cosmonic submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:06):vados-cosmonic created PR review comment:
Updated!
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:06):vados-cosmonic requested dicej for a review on PR #10666.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:16):dicej submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:16):dicej created PR review comment:
This should probably just be
text-- the reader doesn't need to cut-and-paste command output.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:16):dicej created PR review comment:
This one's tricky because they'll need to edit the content after cut-and-pasting it before running. Maybe we should use the same strategy here as we do on line 43, e.g.
cargo +nightly fuzz run $MY_FUZZ_TARGET $MY_TEST_CASE
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:38):vados-cosmonic submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:38):vados-cosmonic created PR review comment:
Yeah, so I thought about making this text, but technically they should see it in the console... Will change this to text!
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:39):vados-cosmonic submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:39):vados-cosmonic created PR review comment:
Ah good point -- Yes, I think using some well named fill-in ENV vars is better here
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:40):vados-cosmonic requested dicej for a review on PR #10666.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:40):vados-cosmonic commented on PR #10666:
Thanks for the reviews @dicej ! Addressed the feed back :bow:
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:41):vados-cosmonic edited a comment on PR #10666:
Thanks for the reviews @dicej ! Addressed the feedback :bow:
Wasmtime GitHub notifications bot (May 01 2025 at 13:38):dicej submitted PR review.
Wasmtime GitHub notifications bot (May 01 2025 at 15:17):alexcrichton closed without merge PR #10666.
Wasmtime GitHub notifications bot (May 01 2025 at 15:18):alexcrichton commented on PR #10666:
Er ok sorry so this was stuck in "Checking mergabilty..." so I thought I could kick github into action by closing/reopening it. Now it's not letting me reopen this, though... @vados-cosmonic mind re-sending this? (or maybe you can reopen it?)
Wasmtime GitHub notifications bot (May 01 2025 at 15:18):alexcrichton commented on PR #10666:
Well now it's letting me reopen ... ?
Wasmtime GitHub notifications bot (May 01 2025 at 15:19):alexcrichton commented on PR #10666:
Well, I swear it gave me a button "Reopen and comment", I hit it, and then it stayed closed... I don't think github likes me right now. I no longer have the possibility of hitting the button...
Wasmtime GitHub notifications bot (May 02 2025 at 08:40):vados-cosmonic commented on PR #10666:
Hery @alexcrichton no worries! I'll re-open this. Weirdly enough it's not showing the re-open button for me either? I guess no one gets to re-create this PR :sweat_smile:
Last updated: Dec 06 2025 at 06:05 UTC