Stream: git-wasmtime

Topic: wasmtime / PR #10660 asm: simplify visiting `Amode` regis...

Wasmtime GitHub notifications bot (Apr 23 2025 at 20:34):

abrown opened PR #10660 from abrown:asm-visit-amode to bytecodealliance:main:

Previously, the Amode::registers_mut method returned a list of registers that generated code iterated over. This was because it was difficult to capture the type needed for constraining the Amode (i.e., Registers::ReadGpr). This change moves that functionality to a helper function with identical behavior, simplifying the generated code and API surface.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 23 2025 at 20:34):

abrown requested fitzgen for a review on PR #10660.

Wasmtime GitHub notifications bot (Apr 23 2025 at 20:34):

abrown requested wasmtime-compiler-reviewers for a review on PR #10660.

Wasmtime GitHub notifications bot (Apr 23 2025 at 20:41):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 23 2025 at 20:41):

alexcrichton has enabled auto merge for PR #10660.

Wasmtime GitHub notifications bot (Apr 23 2025 at 21:11):

alexcrichton merged PR #10660.

Last updated: Dec 06 2025 at 07:03 UTC