Wasmtime GitHub notifications bot (Apr 23 2025 at 18:55): Wasmtime GitHub notifications bot (Apr 23 2025 at 18:55):sunfishcode opened PR #10657 from sunfishcode:sunfishcode/builtins to bytecodealliance:main:
With this patch, all emitted calls are Wasmtime-style builtins, rather than Cranelift-style libcalls. This ensures that all calls from Cranelift-generated code into Wasmtime host code use the same mechanism, and eliminates the relocation handling code for the libcall mechanism.
This is split out from #9093.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:55):sunfishcode requested abrown for a review on PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:55):sunfishcode requested wasmtime-compiler-reviewers for a review on PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:55):sunfishcode requested pchickey for a review on PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:55):sunfishcode requested wasmtime-core-reviewers for a review on PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:55):sunfishcode requested wasmtime-default-reviewers for a review on PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 19:06):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 23 2025 at 19:06):alexcrichton created PR review comment:
In combination with dropping these methods below, could this be changed to
unreachable()in the same manner asi8x16? Fixing this would otherwise require updates to the macro to have a separate "finger" for float registers as it has for integer registers right now, so this'll need more updates if floats are ever passed here.
Wasmtime GitHub notifications bot (Apr 23 2025 at 19:06):alexcrichton created PR review comment:
This is technically incorrect because floats are stored in
FRegVal, notXRegVal. I see this is added here for the various macro machinations for crossing between Pulley and the host. Could this be dropped coupled with the suggestion above as well?
Wasmtime GitHub notifications bot (Apr 23 2025 at 19:12):sunfishcode updated PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 19:19):sunfishcode updated PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 19:25):sunfishcode created PR review comment:
Done.
Wasmtime GitHub notifications bot (Apr 23 2025 at 19:25):sunfishcode submitted PR review.
Wasmtime GitHub notifications bot (Apr 23 2025 at 19:26):sunfishcode submitted PR review.
Wasmtime GitHub notifications bot (Apr 23 2025 at 19:26):sunfishcode created PR review comment:
Done.
Wasmtime GitHub notifications bot (Apr 23 2025 at 19:47):sunfishcode commented on PR #10657:
The failure was:
8.538 E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/liba/libarchive/libarchive13_3.6.0-1ubuntu1.4_amd64.deb 404 Not Found [IP: 91.189.91.83 80]
8.538 E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?so, trying again.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:10):sunfishcode updated PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:21):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:21):alexcrichton created PR review comment:
Mind also deleting these setters too? (fine to do in a follow-up too)
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:21):sunfishcode has enabled auto merge for PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:22):sunfishcode has disabled auto merge for PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:22):sunfishcode updated PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:22):sunfishcode has enabled auto merge for PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:23):sunfishcode submitted PR review.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:23):sunfishcode created PR review comment:
Done.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:31):sunfishcode updated PR #10657.
Wasmtime GitHub notifications bot (Apr 23 2025 at 21:43):sunfishcode updated PR #10657.
Wasmtime GitHub notifications bot (Apr 24 2025 at 01:12):sunfishcode updated PR #10657.
Wasmtime GitHub notifications bot (Apr 24 2025 at 04:44):sunfishcode updated PR #10657.
Wasmtime GitHub notifications bot (Apr 24 2025 at 05:27):sunfishcode merged PR #10657.
Last updated: Dec 06 2025 at 06:05 UTC