Wasmtime GitHub notifications bot (Apr 23 2025 at 18:07): Wasmtime GitHub notifications bot (Apr 23 2025 at 18:07):alexcrichton opened PR #10654 from alexcrichton:unify-guest-programs to bytecodealliance:main:
This commit folds all C/C++ tests for debuginfo into the same location as Rust programs compiled to wasm. That means that all of
tests/all/debug/testsuite/*is moved to
crates/test-programs/src/bin/*. Additionally the hardcoded per-test configuration incrates/test-programs/artifacts/build.rswas removed in favor of in-test configuration at the top of the file. This means that all precompiled binaries are removed from the tree for DWARF testing.Various offsets were updated, a test was dropped as it wasn't used, and some commands/directives were updated to account for this adjustment.
prtest:debug
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:07):alexcrichton requested dicej for a review on PR #10654.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:07):alexcrichton requested wasmtime-core-reviewers for a review on PR #10654.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:07):alexcrichton requested wasmtime-default-reviewers for a review on PR #10654.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:07):alexcrichton edited PR #10654:
This commit folds all C/C++ tests for debuginfo into the same location as Rust programs compiled to wasm. That means that all of
tests/all/debug/testsuite/*is moved to
crates/test-programs/src/bin/*. Additionally the hardcoded per-test configuration incrates/test-programs/artifacts/build.rswas removed in favor of in-test configuration at the top of the file. This means that all precompiled binaries are removed from the tree for DWARF testing.Various offsets were updated, a test was dropped as it wasn't used, and some commands/directives were updated to account for this adjustment.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:08):alexcrichton commented on PR #10654:
cc @SingleAccretion for the affect this has on debuginfo tests
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:27):alexcrichton updated PR #10654.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:37):alexcrichton updated PR #10654.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:42):pchickey submitted PR review:
LGTM, but also a good idea to have someone with deeper understanding of the C/C++ tests spot check.
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:42):pchickey created PR review comment:
/// machines. The `Option` here encapsulates tests that were not able to be
Wasmtime GitHub notifications bot (Apr 23 2025 at 18:42):pchickey created PR review comment:
/// For tests that were not able to be built their error is deferred to
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:22):alexcrichton updated PR #10654.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:51):SingleAccretion submitted PR review:
Changes LGTM. FWIW, I tend[ed] to view the hardcoded compile options as an explicit benefit due to fewer indirections required for understanding where they come from. But this version is also completely fine.
Wasmtime GitHub notifications bot (Apr 23 2025 at 20:51):SingleAccretion submitted PR review:
Changes LGTM. FWIW, I tend[ed] to view the hardcoded compile options as an explicit benefit due to fewer indirections required for understanding of where they come from. But this version is also completely fine.
Wasmtime GitHub notifications bot (Apr 24 2025 at 14:55):dicej submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2025 at 14:55):dicej created PR review comment:
Was this meant to be included, or was it temporarily added for debugging?
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:49):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:49):alexcrichton created PR review comment:
Ah yes this is intentional, this way if a test fails the path to the wasm being processed can be found, otherwise it was not easy to find
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:52):alexcrichton updated PR #10654.
Wasmtime GitHub notifications bot (Apr 24 2025 at 17:52):alexcrichton has enabled auto merge for PR #10654.
Wasmtime GitHub notifications bot (Apr 24 2025 at 20:16):alexcrichton updated PR #10654.
Wasmtime GitHub notifications bot (Apr 24 2025 at 20:16):alexcrichton has enabled auto merge for PR #10654.
Wasmtime GitHub notifications bot (Apr 24 2025 at 20:51):alexcrichton merged PR #10654.
Last updated: Dec 06 2025 at 06:05 UTC